fix(deps): Project-Logos Pattern B (mixed) — VC-53686#3
Open
torresashjiancyber wants to merge 1 commit into
Open
fix(deps): Project-Logos Pattern B (mixed) — VC-53686#3torresashjiancyber wants to merge 1 commit into
torresashjiancyber wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to address supply-chain scan findings (VC-53686) by adding a release-time verification process (checksums + Sigstore signing) and publishing an SBOM alongside release artifacts, plus documenting verification steps for end users.
Changes:
- Added a GitHub Actions workflow that downloads release assets, generates SHA-256 checksums, signs them with cosign keyless signing, and uploads security artifacts back to the release.
- Added a release-notes appendix step to publish verification instructions on each release.
- Updated
.github/README.mdwith checksum/signature verification and SBOM download guidance.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
.github/workflows/release-security.yml |
New workflow to generate/sign checksums, produce an SBOM artifact, upload them to the release, and append verification instructions to release notes. |
.github/README.md |
Documentation updates describing how to verify downloads (checksums + cosign) and where to find the SBOM. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Generate SBOM | ||
| run: | | ||
| cat > release-artifacts/sbom.json <<'EOF' |
Comment on lines
+29
to
+36
| gh release download ${{ github.event.release.tag_name }} \ | ||
| --repo ${{ github.repository }} \ | ||
| --pattern "*.zip" | ||
|
|
||
| - name: Generate SHA-256 checksums | ||
| run: | | ||
| cd release-artifacts | ||
| sha256sum *.zip > checksums.txt |
Comment on lines
+124
to
+126
| CURRENT_BODY=$(gh release view ${{ github.event.release.tag_name }} --json body -q .body) | ||
| NEW_BODY="${CURRENT_BODY}\n\n$(cat verification-instructions.md)" | ||
|
|
Comment on lines
+47
to
+82
| - name: Generate SBOM | ||
| run: | | ||
| cat > release-artifacts/sbom.json <<'EOF' | ||
| { | ||
| "bomFormat": "CycloneDX", | ||
| "specVersion": "1.4", | ||
| "version": 1, | ||
| "metadata": { | ||
| "timestamp": "$(date -u +%Y-%m-%dT%H:%M:%SZ)", | ||
| "component": { | ||
| "type": "application", | ||
| "name": "vssh-cli", | ||
| "version": "${{ github.event.release.tag_name }}", | ||
| "purl": "pkg:github/venafi/vssh-cli@${{ github.event.release.tag_name }}", | ||
| "externalReferences": [ | ||
| { | ||
| "type": "vcs", | ||
| "url": "https://github.com/venafi/vssh-cli" | ||
| }, | ||
| { | ||
| "type": "website", | ||
| "url": "https://www.cyberark.com/products/ssh-manager-for-machines/" | ||
| } | ||
| ] | ||
| }, | ||
| "licenses": [ | ||
| { | ||
| "license": { | ||
| "id": "Apache-2.0" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "components": [] | ||
| } | ||
| EOF |
|
|
||
| ### Verifying Downloads | ||
|
|
||
| For security, all releases include SHA-256 checksums and cryptographic signatures. We recommend verifying your download before use. |
Comment on lines
+113
to
+116
| --bundle checksums.txt.bundle \ | ||
| --certificate-identity-regexp "^https://github.com/venafi/vssh-cli" \ | ||
| --certificate-oidc-issuer https://token.actions.githubusercontent.com \ | ||
| checksums.txt |
Comment on lines
+79
to
+82
| --bundle checksums.txt.bundle \ | ||
| --certificate-identity-regexp "^https://github.com/venafi/vssh-cli" \ | ||
| --certificate-oidc-issuer https://token.actions.githubusercontent.com \ | ||
| checksums.txt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses security findings from Project Logos supply chain scan (VC-53686) by implementing cryptographic verification for release artifacts and publishing a Software Bill of Materials (SBOM).
Findings addressed
High - SC-001 (CWE-494): Installer downloads and executes release binary without checksum or signature
Solution: Created automated GitHub Actions workflow that:
Medium - SC-002 (CWE-1059): No dependency manifest or SBOM published
Solution: The workflow now:
Changes
New workflow:
.github/workflows/release-security.ymlUpdated documentation:
.github/README.mdLocal verification
Next steps
After merge, the next release will automatically include:
checksums.txt- SHA-256 hashes for all artifactschecksums.txt.bundle- Cosign signature bundlesbom.json- CycloneDX Software Bill of Materials